Fix packing of CRCs into the beacon #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gregbreen |
|
Hi @beitler . No it does not unfortunately. In that case, the radio is not getting the frame, so no chance for the payload CRC error to be detected. |
|
This PR is also needed to fix the beacons: #132 |
beitler
added a commit
that referenced
this pull request
Jan 31, 2022
* deps: Updated sx1302_hal dependency to version 2.1.0 (no LBT yet) (Resolves #89, #103, #121, #130) * deps: Added sx1302_hal patch for handling of latched xticks rollover * deps: Updated mbedTLS dependency to version 2.28.0 (LTS) * deps: Fixed lgw patch causing IQ inversion in 500kHz channel (Resolves #81) * s2e: Added support for AU915 (Resolves #43) * s2e: Added support for LoRaWAN Regional Parameters Common Names (Resolves #18) * s2e: Fixed dnchnl2 issue (Resolves #79) * s2e: Fixed class C backoff logic (Resolves #87) * s2e: Fixed class B beacon format (Resolves #129, #131) * s2e: Fixed DR range check in upchannels list parser (Resolves #141) * ral: Changed handling of xticks for lgw1302 * ral: Fixed radio in use issue (Resolves #53, #62) * ral: Fixed types in txpow assignment (master/slave) (Resolves #118) * ral: Fixed class B beacon parameters (Resolves #132) * sx130xconf: Fixed parsing of rssi_tcomp values for sx1302 (Resolves #144) * tls: Fixed TLS cert parsing issue (Resolves #76) * sys_linux: Added support for usb/spi prefix in radio devname * sys_linux: Added mbedTLS version to startup log * sys_linux: Changed version to be printed to stdout (Resolves #51) * sys_linux: Changed default max dbuf size (Resolves #95) * sys_linux: Fixed relative home path handling (Resolves #140) * sys_linux: Fixed memory corruption during system command execution (Resolves #146) * tc/cups: Fixed sync on credset file IO (Resolves #94) * timesync: Fixed UTC to PPS alignment * log: Changed verbosity of XDEBUG log level * log: Changed logging experience for improved clarity * log: Added HAL log integration into logging module * make: Changed makefiles for more space-friendliness (Resolves #66) * net: Changed strictness on line-endings in key files (Resolves #68) * gps: Fixed parsing of ublox NAV-TIMEGPS message * Restored LICENSE file (Resolves #63, #67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small thing I noticed while trying to get Class B working (which I still have not).